fix(email-config): Do not prompt for email configuration issues when email notifications are disabled

[lyjjl]

issue: #690

Summary by Sourcery

Bug Fixes:

• 当通知被禁用时，跳过电子邮件配置验证错误，防止用户因 SMTP 设置为空而被阻塞。

Original summary in English

Summary by Sourcery

Bug Fixes:

• Skip email configuration validation errors when notifications are disabled, preventing users from being blocked by empty SMTP settings.

[sourcery-ai]

评审者指南（在小型 PR 上折叠）

评审者指南

当邮件通知被禁用时，通过对已禁用配置短路验证，允许在没有 SMTP 详细信息的情况下保存邮件配置。

邮件配置验证（通知已禁用时）的时序图

sequenceDiagram
  actor User
  participant UI
  participant EmailConfigManager

  User->>UI: submitEmailConfig(config)
  UI->>EmailConfigManager: validateConfig(config)
  alt emailNotificationsDisabled
    EmailConfigManager-->>UI: ValidationResult(valid: true, errors: [])
  else emailNotificationsEnabled
    EmailConfigManager->>EmailConfigManager: check smtp.host
    EmailConfigManager->>EmailConfigManager: check other smtp fields
    EmailConfigManager-->>UI: ValidationResult(valid: boolean, errors: string[])
  end

  UI-->>User: showSaveResult()

Loading

EmailConfigManager 验证变更的类图

classDiagram
  class EmailConfig {
    bool enabled
    SmtpConfig smtp
  }

  class SmtpConfig {
    string host
    int port
    string username
    string password
  }

  class ValidationResult {
    bool valid
    string[] errors
  }

  class EmailConfigManager {
    +ValidationResult validateConfig(EmailConfig config)
  }

  EmailConfig o-- SmtpConfig
  EmailConfigManager ..> EmailConfig
  EmailConfigManager ..> ValidationResult
  EmailConfigManager ..> SmtpConfig

Loading

文件级变更

变更	详情	文件
当邮件通知被禁用时短路邮件配置验证，从而接受空的 SMTP 设置。	在邮件配置验证中，当邮件功能开关被禁用时添加提前返回，将配置标记为有效并返回无错误 在邮件通知启用时保持现有的 SMTP host 非空验证逻辑不变	src/common/emailConfig.ts

可能关联的问题

• [BUG] 未启用掉线邮件通知时不应提示邮件配置错误 #690：本 PR 将验证调整为在邮件通知被禁用时返回成功，修复了 issue [BUG] 未启用掉线邮件通知时不应提示邮件配置错误 #690 中描述的错误提示。

---

提示与命令

与 Sourcery 交互

• 触发新的评审： 在 pull request 上评论 @sourcery-ai review。
• 继续讨论： 直接回复 Sourcery 的评审评论。
• 从评审评论生成 GitHub issue： 通过回复评审评论让 Sourcery 从该评论创建一个 issue。你也可以在评审评论下回复 @sourcery-ai issue 来从该评论创建 issue。
• 生成 pull request 标题： 在 pull request 标题的任意位置写上 @sourcery-ai 即可随时生成标题。你也可以在 pull request 上评论 @sourcery-ai title 来（重新）生成标题。
• 生成 pull request 摘要： 在 pull request 正文任意位置写上 @sourcery-ai summary，即可在你想要的位置随时生成 PR 摘要。你也可以在 pull request 上评论 @sourcery-ai summary 来（重新）生成摘要。
• 生成评审者指南： 在 pull request 上评论 @sourcery-ai guide，即可随时（重新）生成评审者指南。
• 解决所有 Sourcery 评论： 在 pull request 上评论 @sourcery-ai resolve，即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们，这会很有用。
• 撤销所有 Sourcery 评审： 在 pull request 上评论 @sourcery-ai dismiss，即可撤销所有现有的 Sourcery 评审。尤其适用于你希望从一次全新的评审开始——别忘了再评论 @sourcery-ai review 来触发新一轮评审！

自定义你的使用体验

前往你的 控制台 以：

• 启用或禁用评审功能，比如 Sourcery 生成的 pull request 摘要、评审者指南等。
• 更改评审语言。
• 添加、删除或编辑自定义评审说明。
• 调整其他评审设置。

获取帮助

• 如有问题或反馈，请联系支持团队。
• 访问我们的文档以获取详细指南和信息。
• 关注我们的 X/Twitter、LinkedIn 或 GitHub，与 Sourcery 团队保持联系。

Original review guide in English

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Allows saving email configuration without SMTP details when email notifications are disabled by short-circuiting validation for disabled configurations.

Sequence diagram for email configuration validation with disabled notifications

sequenceDiagram
  actor User
  participant UI
  participant EmailConfigManager

  User->>UI: submitEmailConfig(config)
  UI->>EmailConfigManager: validateConfig(config)
  alt emailNotificationsDisabled
    EmailConfigManager-->>UI: ValidationResult(valid: true, errors: [])
  else emailNotificationsEnabled
    EmailConfigManager->>EmailConfigManager: check smtp.host
    EmailConfigManager->>EmailConfigManager: check other smtp fields
    EmailConfigManager-->>UI: ValidationResult(valid: boolean, errors: string[])
  end

  UI-->>User: showSaveResult()

Loading

Class diagram for EmailConfigManager validation change

classDiagram
  class EmailConfig {
    bool enabled
    SmtpConfig smtp
  }

  class SmtpConfig {
    string host
    int port
    string username
    string password
  }

  class ValidationResult {
    bool valid
    string[] errors
  }

  class EmailConfigManager {
    +ValidationResult validateConfig(EmailConfig config)
  }

  EmailConfig o-- SmtpConfig
  EmailConfigManager ..> EmailConfig
  EmailConfigManager ..> ValidationResult
  EmailConfigManager ..> SmtpConfig

Loading

File-Level Changes

Change	Details	Files
Short-circuit email configuration validation when email notifications are disabled so empty SMTP settings are accepted.	Add an early return in email configuration validation when the email feature flag is disabled, marking the config as valid and returning no errors Keep existing SMTP host non-empty validation logic for when email notifications are enabled	src/common/emailConfig.ts

Possibly linked issues

• [BUG] 未启用掉线邮件通知时不应提示邮件配置错误 #690: PR changes validation to return success when email notifications are disabled, fixing erroneous prompts described in issue [BUG] 未启用掉线邮件通知时不应提示邮件配置错误 #690.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - 我已经审查了你的更改，看起来很棒！

---

Sourcery 对开源项目是免费的——如果你觉得我们的审查有帮助，欢迎分享 ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的审查。}

Original comment in English

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[linyuchen]

感谢 PR