-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: auto-close after commit+push with multiple commits [INS-1948] #9608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: auto-close after commit+push with multiple commits [INS-1948] #9608
Conversation
✅ Circular References ReportGenerated at: 2026-01-29T15:01:38.755Z Summary
Click to view all circular references in PR (85)Click to view all circular references in base branch (85)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refines the Git project staging modal’s commit/push handling so that commit results are interpreted more robustly and the UI behaves correctly for commit+push flows, especially when using AI-generated multiple commits.
Changes:
- Updated
onCommitSuccessacrossGeneratedCommitsForm,ManualCommitForm, andGitProjectStagingModalto receive a{ push: boolean }payload, allowing the modal to distinguish between plain commits and commit+push. - Refactored the
useEffectlogic for both single-commit and multi-commit flows to more accurately classify success vs. error responses using theerrorsarray and (where applicable) asuccessflag from the main process. - Added a success toast (“Changes committed and pushed”) and immediate modal close for successful commit+push operations from the project staging modal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/insomnia/src/ui/components/modals/git-project-staging-modal.tsx
Outdated
Show resolved
Hide resolved
packages/insomnia/src/ui/components/modals/git-project-staging-modal.tsx
Outdated
Show resolved
Hide resolved
7f3d68d to
bf9302c
Compare
bf9302c to
b5bbf7c
Compare
useEffectlogic to embed success/error checks