Use tags to get next/prev unreviewed files#363
Conversation
Deploying bats-ai with
|
| Latest commit: |
250fa42
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7948c312.bats-ai.pages.dev |
| Branch Preview URL: | https://make-filter-tag-state-shared.bats-ai.pages.dev |
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
In Spectrogram.vue we also have RecordingList.vue which is a list of the top 20 recordings, we probably have to apply the same tag filtering to that if we are doing it for the next and previous.
client/src/views/Spectrogram.vue
Outdated
| const currentRecording = await getRecording(props.id); | ||
| let tags = []; | ||
| if (currentRecording.data.owner_username === currentUser.value) { | ||
| tags = filterTags.value; | ||
| } else { | ||
| tags = sharedFilterTags.value; | ||
| } |
There was a problem hiding this comment.
I'm wondering if this logic should be more complicated?
I know that our current users will have configuration.non_admin_upload_enabled set to false.
The next/previous is active on both the shared and their own filter tags. This logic would make the next/previous not cyclical. I.E if you go are going through shared recordings and happen to hit your own recording all of a sudden the list of recordings changes.
Posible solutions:
- Combining and getting a unique list of tags for your own and shared recordings I.E
tags = [...FilterTags.value, ...sharedFilterTags.value].unique()(pseudocode) - Swapping the backend so it takes the own recording tags and the shared filter tags separately. I.E the end point as ownedTags and sharedTags that are submitted when getting the next/previous
There was a problem hiding this comment.
Let's go with option 1 for now. If we need, we can revisit this logic.
| clearContours, | ||
| currentRecordingId, | ||
| viewMaskOverlay, | ||
| filterTags, |
There was a problem hiding this comment.
Should we in the template show what the filtering tags are in the UI? I.E some indication that this is filtered data on a tag/tags?
Just thinking of the case of someone copying a link to another PC for a spectrogram (this wouldn't copy over the local storage tags) and they start hitting next/previous. Maybe inbetween the Prev/Next buttons adding the tag just as an indication that the data is filtered. Show the tag only if it exists.
naglepuff
force-pushed
the
make-filter-tag-state-shared
branch
from
37404d1 to
250fa42
Compare
2 participants
No description provided.