add deduction guides for Struct from std::tuple (Fix for C++23 on gcc 15) #525
Conversation
C++23 changed the generation of implicit deduction guides. This causes the compiler to also see deduction guides for std::tuple as candidates for sdbus::Struct. Because of the competing guides the compiler doesn't know which one to pick. This seems to be implemented from gcc 15 on and is thus causing breakage there. To fix this we need to add explicit deduction guides when std::tuple is passed to sdbus::Struct. fixes Kistler-Group#524
heinemml
changed the title
|
@heinemml Thanks for reporting the issue and the PR. I'm fine with that except of a little detail -- we need to remove |
We need to be able to create sdbus::Structs with element types being references.
|
I already did it. |
|
Unit tests would have failed on the original |
2 participants
C++23 changed the generation of implicit deduction guides. This causes the compiler to also see deduction guides for
std::tupleas candidates forsdbus::Struct.Because of the competing guides the compiler doesn't know which one to pick.
This seems to be implemented from gcc 15 on and is thus causing breakage there.
To fix this we need to add explicit deduction guides when std::tuple is passed to
sdbus::Struct.fixes #524