feat: add export support #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sdbus-c++ consumable from the build tree without the need for an explicit installation. This can be very handy for e.g. testing purposes. Crucially, downstream projects will depend on upstream to properly export everything. Otherwise, they can't be built as static libraries, even if sdbus-c++ is only a private dependency. See also https://runebook.dev/en/docs/cmake/command/export
Krzmbrzl
added a commit
to mumble-voip/os-events
that referenced
this pull request
Jan 3, 2026
When building as a static library, the sdbus-c++ dependency can cause issues with exporting as not all versions of it support it. Hence, it can be disabled as needed. See also Kistler-Group/sdbus-cpp#523
sangelovic
reviewed
Jan 5, 2026
Collaborator
sangelovic
left a comment
sangelovic
left a comment
There was a problem hiding this comment.
Your proposal makes much sense. Thank you for the PR!
EXPORT_SET is empty when SDBUSCPP_INSTALL is OFF, which leads to targets file with no targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sdbus-c++ consumable from the build tree without the need for an explicit installation. This can be very handy for e.g. testing purposes. Crucially, downstream projects will depend on upstream to properly export everything. Otherwise, they can't be built as static libraries, even if sdbus-c++ is only a private dependency.
See also https://runebook.dev/en/docs/cmake/command/export