Add VUID for relaxed control barrier with storage class semantics#2495
Merged
oddhack merged 2 commits intoKhronosGroup:mainfrom Mar 7, 2025
Merged
Conversation
Add a new VUID for a relaxed control barrier with non-zero storage class semantics. PR in SPIRV-Tools: KhronosGroup/SPIRV-Tools#5984 Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com>
|
|
oddhack
reviewed
Feb 19, 2025
appendices/spirvenv.adoc
Outdated
| code:AcquireRelease, or code:SequentiallyConsistent memory semantics | ||
| * [[VUID-{refpage}-OpMemoryBarrier-04733]] | ||
| code:OpMemoryBarrier must: include at least one {StorageClass} | ||
| * [[VUID-{refpage}-OpControlBarrier-04649]] |
Contributor
There was a problem hiding this comment.
VUIDs are assigned as part of the spec update process, so please remove this anchor.
There was a problem hiding this comment.
Like
* If the semantics for code:OpControlBarrier includes at least one {StorageClass},
then it must: include one of code:Acquire, code:Release, code:AcquireRelease,
or code:SequentiallyConsistent memory semantics
Contributor
Author
There was a problem hiding this comment.
Fixed, thank you
Contributor
|
Handing off to the memory model TSG to review. |
Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com>
Contributor
|
Memory Model TSG approved this PR. |
evysgarden
pushed a commit
to evysgarden/Vulkan-Docs
that referenced
this pull request
Jun 19, 2025
…ronosGroup#2495) * Add VUID for relaxed control barrier with storage class semantics Add a new VUID for a relaxed control barrier with non-zero storage class semantics. PR in SPIRV-Tools: KhronosGroup/SPIRV-Tools#5984 Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com> * Remove hardcoded VUID Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com> --------- Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com>
evysgarden
pushed a commit
to evysgarden/Vulkan-Docs
that referenced
this pull request
Jun 21, 2025
…ronosGroup#2495) * Add VUID for relaxed control barrier with storage class semantics Add a new VUID for a relaxed control barrier with non-zero storage class semantics. PR in SPIRV-Tools: KhronosGroup/SPIRV-Tools#5984 Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com> * Remove hardcoded VUID Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com> --------- Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com>
evysgarden
pushed a commit
to evysgarden/Vulkan-Docs
that referenced
this pull request
Jun 21, 2025
…ronosGroup#2495) * Add VUID for relaxed control barrier with storage class semantics Add a new VUID for a relaxed control barrier with non-zero storage class semantics. PR in SPIRV-Tools: KhronosGroup/SPIRV-Tools#5984 Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com> * Remove hardcoded VUID Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com> --------- Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new VUID for a relaxed control barrier with non-zero storage class semantics. PR in SPIRV-Tools:
KhronosGroup/SPIRV-Tools#5984