Use workspace:* for eslint-plugin-wonder-blocks dep in the project#3014
Use workspace:* for eslint-plugin-wonder-blocks dep in the project#3014beaesguerra wants to merge 14 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 4dfa9bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
npm Snapshot: NOT Published🤕 Oh noes!! We couldn't find any changesets in this PR (6dc39b0). As a result, we did not publish an npm snapshot for you. |
|
Size Change: 0 B Total Size: 122 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-hwbstvvsva.chromatic.com/ Chromatic results:
|
beaesguerra
force-pushed
the
update-plugin-dep
branch
2 times, most recently
from
32c935b to
fb12152
Compare
beaesguerra
force-pushed
the
update-plugin-dep
branch
from
fb12152 to
613d347
Compare
beaesguerra
force-pushed
the
update-plugin-dep
branch
from
d4476db to
3a750c1
Compare
…be built before it is used
beaesguerra
changed the title
| packages/eslint-plugin-wonder-blocks/demo | ||
|
|
||
| # ignore auto-generated util type files | ||
| utils/**/*.d.ts |
There was a problem hiding this comment.
This ignores lint errors on auto-generated type files (this is in our gitignore as well!)
It addresses this error when we lint after building: https://github.com/Khan/wonder-blocks/actions/runs/24539136579/job/71741015598?pr=3014
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
2 participants
Summary:
Previously, the CI lint step would fail to find the plugin when we use the
workspace:*version of theeslint-plugin-wonder-blockspackage (context).To fix this, we make sure we build the packages before the linting step, so that the plugin can be used.
This would mean that the wb repo will use the current version of the eslint plugin, rather than the last released version!
Issue: WB-2308
Test plan:
Confirm checks pass.