Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Naeemkh
requested changes
Apr 30, 2026
Member
Naeemkh
left a comment
Naeemkh
left a comment
There was a problem hiding this comment.
Thanks, @amazloumi, please see the comments.
| The `marketplace list` step is a sanity check: `kempnerforge` should appear under "Configured marketplaces". If it doesn't, the add silently failed; re-check the absolute path. | ||
|
|
||
| v0.1 ships six skills: `cluster-config`, `smoke-test`, `slurm-launch`, `explain-architecture`, `add-optimizer`, `component-gaps`. Full catalog, install details, and how skills stay in sync with the code: [`docs/claude-ready.md`](docs/claude-ready.md). | ||
| v0.1 ships seven skills: `install-and-verify`, `cluster-config`, `smoke-test`, `slurm-launch`, `explain-architecture`, `add-optimizer`, `component-gaps`. Full catalog, install details, and how skills stay in sync with the code: [`docs/claude-ready.md`](docs/claude-ready.md). |
Member
There was a problem hiding this comment.
Let's drop the number (seven here), so future updates does not need to change this number.
|
|
||
| ## When to use | ||
| - Right after `git clone`, before any other skill. | ||
| - After `git pull` brings new dependency changes (`pyproject.toml` or `uv.lock`). |
Member
There was a problem hiding this comment.
This can be too much during development and time consuming, I understand running it once after git clone, but after each git pull is too much. You might consider changing the wording to
Optionally after git pull if the user asks for it.
Also mention to run it in the background as subprocess.
|
|
||
| On `NO_CUDA`, **print this warning to the user verbatim** before proceeding, and append `--no-sources` to every `uv run` and `uv sync` invocation in this skill (the flag is per-command, not sticky): | ||
|
|
||
| > ⚠️ No CUDA GPU detected. Using `--no-sources` to fetch torch from PyPI instead of the CUDA wheel index. Sufficient for the dev loop (lint, type-check, CPU unit tests); training and GPU tests still need a Linux GPU box. Note: `--no-sources` also bypasses any other `[tool.uv.sources]` entries the project may add later. |
| The `marketplace list` step is a sanity check: `kempnerforge` should appear under "Configured marketplaces". If it doesn't, the add silently failed; re-check the absolute path. | ||
|
|
||
| v0.1 ships six skills: `cluster-config`, `smoke-test`, `slurm-launch`, `explain-architecture`, `add-optimizer`, `component-gaps`. Full catalog, install details, and how skills stay in sync with the code: [`docs/claude-ready.md`](docs/claude-ready.md). | ||
| v0.1 ships seven skills: `install-and-verify`, `cluster-config`, `smoke-test`, `slurm-launch`, `explain-architecture`, `add-optimizer`, `component-gaps`. Full catalog, install details, and how skills stay in sync with the code: [`docs/claude-ready.md`](docs/claude-ready.md). |
Member
There was a problem hiding this comment.
Also here, please drop the number (seven here).
Naeemkh
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
/kempnerforge:install-and-verifyskill — runsuv syncand the four CI gate checks (ruff check,ruff format --check,pyright,pytest tests/unit/). On non-CUDA hosts (macOS, CPU-only Linux) it appends--no-sourcesto bypass the CUDA-only torch wheel pin and warns the user that this venv is dev-only.Skill catalog grows from six to seven.
README.md,kempnerforge/README.md, anddocs/claude-ready.mdupdated; CHANGELOG records the addition.Testing
--no-sourceswarning behave as documented.uv run ruff check kempnerforge/ tests/passesuv run ruff format --check kempnerforge/ tests/ scripts/passesuv run pyright kempnerforge/passes (0 errors)uv run pytest tests/unit/ -v --timeout=60passesuv run torchrun --nproc_per_node=4 -m pytest tests/distributed/ -vuv run pytest tests/e2e/ --e2e -vNotes
Stacked on PR #72.