Skip to content

Comments

Remove pool import events#11647

Open
jturel wants to merge 1 commit intoKatello:masterfrom
jturel:candlepin_import_events
Open

Remove pool import events#11647
jturel wants to merge 1 commit intoKatello:masterfrom
jturel:candlepin_import_events

Conversation

@jturel
Copy link
Member

@jturel jturel commented Feb 20, 2026

What are the changes introduced in this pull request?

Removes both the "candlepin events" pool import and the "katello events" pool import. These don't seem necessary because:

Considerations taken when implementing this change?

Maintain consistency

What are the testing steps for this pull request?

  • Create a custom product and verify that the correct pools are created (ie same before and after this change)
  • Import a manifest with subscriptions and verify that the correct pools are created (ie same before and after this change)

Summary by Sourcery

Remove handling of Candlepin pool.created events and related ImportPool event processing now that pool synchronization is handled elsewhere.

Enhancements:

  • Remove the ImportPool event type, handler, and registration from the event processing pipeline.
  • Simplify Candlepin message handling by dropping pool creation import logic and relying on existing pool reconciliation mechanisms.

Tests:

  • Clean up and update event handling tests to reflect removal of pool.created and ImportPool behavior.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant