Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Removes both the "candlepin events" pool import and the "katello events" pool import. These don't seem necessary because:
Custom product creation creates its own pool
katello/app/models/katello/glue/candlepin/product.rb
Line 121 in 79fa7bd
Manifest import & refresh do a full reconciliation against Candlepin pools for the given org
katello/app/models/katello/glue/provider.rb
Line 153 in 79fa7bd
Considerations taken when implementing this change?
Maintain consistency
What are the testing steps for this pull request?
Summary by Sourcery
Remove handling of Candlepin pool.created events and related ImportPool event processing now that pool synchronization is handled elsewhere.
Enhancements:
Tests: