Conversation
1a7310f to
32eb9e1
Compare
Nikitae57
left a comment
There was a problem hiding this comment.
changeBluetoothStateUsingAdbServer method needs attention. Everything else either minor or LGTM
| logger.i("Bluetooth is not supported") | ||
| return | ||
| } | ||
| logger.i("${if (enable) "En" else "Dis"}able bluetooth") |
There was a problem hiding this comment.
Please, make two separate calls to the logger. Concatenating log strings make them almost imposible to find in the code
|
Hi! why you don't use more stable way to turn on/off bluetooth For disabling you can use same adb command "adb shell am start - a android.bluetooth.adapter.action.REQUEST_DISABLE" |
| /** | ||
| * The implementation of the [Bluetooth] interface. | ||
| */ | ||
| class BluetoothImpl( |
There was a problem hiding this comment.
if this class is only needed inside our framework and should not be visible outside - let's make it internal to limit the creation of new instances and minimize the side effects of possible breaking changes in this class
No description provided.