Test markdown to html for kurslista#306
Draft
amirhossein-haerian wants to merge 5 commits intoupl-mainfrom
Draft
Test markdown to html for kurslista#306amirhossein-haerian wants to merge 5 commits intoupl-mainfrom
amirhossein-haerian wants to merge 5 commits intoupl-mainfrom
Conversation
* feat(KP-367): the search is now updated with the new data comming from ladok * feat(KP-367): search filters are now working as expected in phase 1 * feat(KP-367): formatted course credits has been used * fix(KP-367): one comment is added * fix(KP-367): change condition for triggering noQueryProvidedDispatch * fix(KP-367): add errorUnKnown as default error message for alerts * the front-end is updated after the upgrade in grouping results from ladok * feat(KP-367): search parameters chnged to only semesters * feat(KP-367): search parameters are changed and the task is ready * change the ladok API usage based on changes in ladok mellan lager
* feat(KP-373): replace the old search with the newer version * fix(KP-373): remove old search from more places
allazis
reviewed
Mar 19, 2025
Contributor
allazis
left a comment
There was a problem hiding this comment.
Really good job on this! The example looks great ⭐
Looking forward to see further work on this, especially for the hybrid program syllabuses using both this and the structures.
4222ce3 to
5374d23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not be merged.
This is a PR to test whether we can show the generated data for Kurslista in Ladok syllabuses.
The data is being converted to HTML inside studadm-om-kursen-packages. another PR is being created on that Repository.
This PR is only working for TITEH program only now.
here is an example: http://localhost:3000/student/kurser/program/TITEH/20181/arskurs3?l=en
Screen shots of the result: