Skip to content

Rewrite docs, focusing on the problem statement#1073

Open
timholy wants to merge 1 commit intoJuliaSmoothOptimizers:mainfrom
timholy:teh/docs_problem_statement
Open

Rewrite docs, focusing on the problem statement#1073
timholy wants to merge 1 commit intoJuliaSmoothOptimizers:mainfrom
timholy:teh/docs_problem_statement

Conversation

@timholy
Copy link
Copy Markdown
Contributor

@timholy timholy commented Feb 22, 2026

Long-overdue, sorry.

This is a "test commit" for a single method. Let me know if you like this and what needs to change. If/when we get to a point where we are happy with the changes, I'll apply similar changes to the other docstrings in the package.

When finished this will fix #1046

Copilot AI review requested due to automatic review settings February 22, 2026 15:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the trimr documentation to better describe the underlying linear system and how preconditioning/warm-starting behave, as a test run before applying similar edits across the package.

Changes:

  • Expanded the problem statement for TriMR, including clearer notation and system description.
  • Added detailed explanation of how M/N and ldiv define preconditioner application.
  • Reorganized/rewrapped the docstring sections (interface, arguments, stopping criteria, references) for readability.
Comments suppressed due to low confidence (1)

src/trimr.jl:123

  • Minor grammar: “for Hermitian and positive-definite linear system” should read “for a Hermitian positive-definite linear system” (and consider aligning singular/plural with the other bullets).
* `spd`: if `true`, set `τ = 1` and `ν = 1` for Hermitian and positive-definite
  linear system;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 32 to +35
Given a matrix `A` of dimension m × n, TriMR solves the symmetric linear system

[ τE A ] [ x ] = [ b ]
[ Aᴴ νF ] [ y ] [ c ],
[ Aᴴ νF ] [ y ] [ c ]
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring says TriMR solves a “symmetric” linear system, but the formulation uses Aᴴ (conjugate transpose) and later refers to a “partitioned Hermitian linear system”. Consider changing this wording to “Hermitian (symmetric if real)” to be accurate and internally consistent.

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.69%. Comparing base (9536ef7) to head (c89736b).
⚠️ Report is 120 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
+ Coverage   94.68%   97.69%   +3.01%     
==========================================
  Files          45       50       +5     
  Lines        8027    10011    +1984     
==========================================
+ Hits         7600     9780    +2180     
+ Misses        427      231     -196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation confusion between preconditioners and the problem being solved

2 participants