Remove special handling of SARTSA traces#75
Merged
jeremiahpslewis merged 3 commits intoJuliaReinforcementLearning:mainfrom Jan 13, 2025
Merged
Remove special handling of SARTSA traces#75jeremiahpslewis merged 3 commits intoJuliaReinforcementLearning:mainfrom
jeremiahpslewis merged 3 commits intoJuliaReinforcementLearning:mainfrom
Conversation
Remove methods specifically defined for SARTSA traces in EpisodesBuffer and CircularPrioritizedTraces
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 74.23% 74.08% -0.15%
==========================================
Files 18 17 -1
Lines 850 822 -28
==========================================
- Hits 631 609 -22
+ Misses 219 213 -6 ☔ View full report in Codecov by Sentry. |
Member
|
@johannes-fischer this looks great, thank you! I’ll give it a review next week |
jeremiahpslewis
approved these changes
Jan 13, 2025
jeremiahpslewis
merged commit 2d25c54
into
JuliaReinforcementLearning:main
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR contains several things:
capacityfunction for predefined traces likeCircularArraySARTSTracesetc. e924768CircularArraySARTSATracesto only the necessary capacity (exactly one additional state and action) e924768Base.push!(t::CircularPrioritizedTraces{<:CircularArraySARTSATraces}, x)and `Base.push!(eb::EpisodesBuffer{<:Any,<:Any,<:CircularArraySARTSATraces}, xs::PartialNamedTuple)function Base.push!(eb::EpisodesBuffer{<:Any,<:Any,<:CircularPrioritizedTraces{<:CircularArraySARTSATraces}}, xs::PartialNamedTuple{@NamedTuple{action::Int64}})