Let @validate check ispolytopic for vertices(_list)#4110
Merged
Conversation
schillic
changed the title
validate check ispolytopic for vertices(_list)@validate check ispolytopic for vertices(_list)
mforets
approved these changes
Feb 5, 2026
schillic
force-pushed
the
schillic/validate_vertices
branch
from
01dca5a to
2e5f7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #4012, this PR is skipping
EmptySetbecause it is currently not defined as polytopic. But I think it should be.Moreover, this PR is skipping
UnionSet(Array). It is unclear to me whether the implementation forUnionSet(Array)is correct. I suggest one should rather broadcast to obtain the result that the current implementation computes.