[librdkafka] Enable zstd support#13171
Merged
giordano merged 4 commits intoJuliaPackaging:masterfrom Feb 21, 2026
Merged
Conversation
aplavin
force-pushed
the
librdkafka-zstd
branch
3 times, most recently
from
dacee70 to
965ae2a
Compare
aplavin
force-pushed
the
librdkafka-zstd
branch
2 times, most recently
from
9a47815 to
f090656
Compare
aplavin
force-pushed
the
librdkafka-zstd
branch
from
f090656 to
3e2c338
Compare
Contributor
Author
|
It works now! Should be ready. |
giordano
requested changes
Feb 20, 2026
| dependencies = [ | ||
| Dependency(PackageSpec(name="Lz4_jll", uuid="5ced341a-0733-55b8-9ab6-a4889d929147"); compat="1.9.4"), | ||
| Dependency(PackageSpec(name="Zstd_jll", uuid="3161d3a3-bdf6-5164-811a-617609db77b4"); compat="1.4.2"), | ||
| Dependency(PackageSpec(name="Zstd_jll", uuid="3161d3a3-bdf6-5164-811a-617609db77b4"); compat="1.5.7"), |
Member
There was a problem hiding this comment.
Must change the version number when changing a compat bound (that's a requirement from the registry)
Contributor
Author
There was a problem hiding this comment.
not sure, what does it mean in practice? update to new libkafka?
Member
There was a problem hiding this comment.
If there's a newer version that'd be ideal, yes
Contributor
Author
There was a problem hiding this comment.
bumped to new version – seems to work
giordano
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zstd_jll is listed as a dependency but cmake's
find_package(ZSTD QUIET)fails silently in the BB environment, so zstd was never actually linked. Adding-DWITH_ZSTD=ONforces it on.