Draft
Conversation
giordano
reviewed
Dec 21, 2024
Comment on lines
+363
to
+367
| "%sysroot%/usr/include", | ||
| "%sysroot%/../include/c++/10.2.0", | ||
| "%sysroot%/../include/c++/10.2.0/$(aatarget)", | ||
| "%sysroot%/../include/c++/10.2.0/backward", | ||
| "%sysroot%/../include/c++/10.2.0/parallel", |
Member
There was a problem hiding this comment.
Hardcoding paths like this doesn't seem good, also because they're specific to the GCC version used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @giordano @gbaraldi
@wsmoses given that Bazel makes it so difficult to get values from env vars, this is actually easier