Open
Conversation
Keno
added a commit
to JuliaPackaging/BinaryBuilder.jl
that referenced
this pull request
Sep 20, 2023
Goes with JuliaPackaging/BinaryBuilderBase.jl#322. Part of the problem with the current setup is that the WizardState doesn't actually round trip properly, because the cache for archive downloads gets deleted. It could be reconstituted from source_urls of course, but it would be cleaner to just do that on-demand with the SetupSource (though this commit doesn't do that yet).
giordano
reviewed
Sep 20, 2023
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
It'd be good to bump the minor version of this package so that we can require that in JuliaPackaging/BinaryBuilder.jl#1293
Keno
force-pushed
the
kf/setupsourceurl
branch
from
e766dce to
2f37701
Compare
Keno
added a commit
to JuliaPackaging/BinaryBuilder.jl
that referenced
this pull request
Sep 20, 2023
Goes with JuliaPackaging/BinaryBuilderBase.jl#322. Part of the problem with the current setup is that the WizardState doesn't actually round trip properly, because the cache for archive downloads gets deleted. It could be reconstituted from source_urls of course, but it would be cleaner to just do that on-demand with the SetupSource (though this commit doesn't do that yet).
Keno
force-pushed
the
kf/setupsourceurl
branch
from
2f37701 to
9f24f17
Compare
Otherwise the wizard needs to keep a separate 1-1 mapping of the urls, which is somewhat silly.
giordano
force-pushed
the
kf/setupsourceurl
branch
from
9f24f17 to
29c0eed
Compare
Member
|
The more I look at this, the more I'm convinced it's a breaking change. That's fine, I don't see any users apart from BinaryBuilder, but we still need to change the major version number not to let people end up with incompatible versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the wizard needs to keep a separate 1-1 mapping of the urls, which is somewhat silly.