remove dead code (detect_libstdcxx_version and check_libstdcxx_version) ?#1394
Open
t-bltg wants to merge 2 commits intoJuliaPackaging:masterfrom
Open
remove dead code (detect_libstdcxx_version and check_libstdcxx_version) ?#1394t-bltg wants to merge 2 commits intoJuliaPackaging:masterfrom
detect_libstdcxx_version and check_libstdcxx_version) ?#1394t-bltg wants to merge 2 commits intoJuliaPackaging:masterfrom
Conversation
Member
|
I never touched this code because I always assumed this was meant to be used at some point, since Julia itself also has mechanisms to detect the libstdc++ version (on Linux do |
Contributor
Author
|
Ok, I wanted to add tests covering these lines, but they were failing, so I'm not sure what to do here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
BinaryBuilder.Auditor.detect_libstdcxx_versionandBinaryBuilder.Auditor.check_libstdcxx_versionis dead code and not used anywhere inBinaryBuilder, also without any traces of usage anywhere else in thejuliaecosystem:https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/master/src/auditor/compiler_abi.jl#L107-L165
So should they be removed ?
Hoisted out of #1392.