Skip to content

Add a Base.SHA256 struct into Base #61555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DilumAluthge wants to merge 3 commits into
base: master
Choose a base branch
from
+30 −27
Draft

Add a Base.SHA256 struct into Base #61555

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5534ab9
Add a `Base.SHA256` struct into Base
DilumAluthge Apr 10, 2026
7ed238b
Fix a mistake
DilumAluthge Apr 12, 2026
6a41a58
Fix a mistake
DilumAluthge Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 30 additions & 27 deletions base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,36 +110,39 @@ function isaccessiblepath(path)
end
end

## SHA1 ##

struct SHA1
bytes::NTuple{20, UInt8}
end
function SHA1(bytes::Vector{UInt8})
length(bytes) == 20 ||
throw(ArgumentError("wrong number of bytes for SHA1 hash: $(length(bytes))"))
return SHA1(ntuple(i->bytes[i], Val(20)))
end
SHA1(s::AbstractString) = SHA1(hex2bytes(s))
parse(::Type{SHA1}, s::AbstractString) = SHA1(s)
function tryparse(::Type{SHA1}, s::AbstractString)
try
return parse(SHA1, s)
catch e
if isa(e, ArgumentError)
return nothing
## SHA1 and SHA256 ##
for (name, namestr, numbytes) in [(:SHA1, "SHA1", 20), (:SHA256, "SHA256", 32)]
@eval Base begin
struct $name
bytes::NTuple{$(numbytes), UInt8}
end
function $name(bytes::Vector{UInt8})
length(bytes) == $numbytes ||
throw(ArgumentError("wrong number of bytes for " * string($namestr) * ": Expected $(numbytes) bytes, got $(length(bytes))"))
return $name(ntuple(i->bytes[i], Val($numbytes)))
end
$name(s::AbstractString) = $name(hex2bytes(s))
parse(::Type{$name}, s::AbstractString) = $name(s)
function tryparse(::Type{$name}, s::AbstractString)
try
return parse($name, s)
catch e
if isa(e, ArgumentError)
return nothing
end
rethrow(e)
end
end
rethrow(e)
end
end

string(hash::SHA1) = bytes2hex(hash.bytes)
print(io::IO, hash::SHA1) = bytes2hex(io, hash.bytes)
show(io::IO, hash::SHA1) = print(io, "SHA1(\"", hash, "\")")
string(hash::$name) = bytes2hex(hash.bytes)
print(io::IO, hash::$name) = bytes2hex(io, hash.bytes)
show(io::IO, hash::$name) = print(io, string($namestr) * "(\"", hash, "\")")
Copy link
Copy Markdown
Member

@jakobnissen jakobnissen Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
show(io::IO, hash::$name) = print(io, string($namestr) * "(\"", hash, "\")")
show(io::IO, hash::$name) = print(io, namestr * "(\"", hash, "\")")


isless(a::SHA1, b::SHA1) = isless(a.bytes, b.bytes)
hash(a::SHA1, h::UInt) = hash((SHA1, a.bytes), h)
==(a::SHA1, b::SHA1) = a.bytes == b.bytes
isless(a::$name, b::$name) = isless(a.bytes, b.bytes)
hash(a::$name, h::UInt) = hash(($name, a.bytes), h)
==(a::$name, b::$name) = a.bytes == b.bytes
end
end

# fake uuid5 function (for self-assigned UUIDs)
# TODO: delete and use real uuid5 once it's in stdlib
Expand Down
Loading