make Meta-e work for editors defined with wait=false
#60887
+15
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If in
define_editorthe keyword argumentwait=falseis used (the default value), then theeditfunction always returns immediately, without waiting for the editor to be closed. As a result, one cannot useMeta-eanymore to edit the current input in an external editor. For this to work, theeditcall used under the hood would have to wait for the editor. This PR fixed this.The solution I propose is to add a keyword argument
waittoedit(for the filename-line-column version only). If it is set totrue, theneditwill wait for the editor to close, no matter whichwaitvalue was used indefine_editor. If thewaitargument foreditisfalse, then the value used fordefine_editoris taken.