fixes Overrides.toml issues on Windows and when using nested CMake projects.#165
Open
mind6 wants to merge 11 commits intoJuliaInterop:mainfrom
Open
fixes Overrides.toml issues on Windows and when using nested CMake projects.#165mind6 wants to merge 11 commits intoJuliaInterop:mainfrom
mind6 wants to merge 11 commits intoJuliaInterop:mainfrom
Conversation
Also: * adds the JLCXX_FORCE_RANGES_OFF compile flag * suppresses warnings when compiling without ranges * bumps version to v0.13.2
Contributor
|
Thanks, but this fails the tests on all platforms with the error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Windows the user directory is found through ENV{USERPROFILE} not ENV{HOME}.
Feel free to clean up comments if you find them excessive.