implements biased IntegralArray for floats#22
Open
mleseach wants to merge 1 commit intoJuliaImages:masterfrom
Open
implements biased IntegralArray for floats#22mleseach wants to merge 1 commit intoJuliaImages:masterfrom
mleseach wants to merge 1 commit intoJuliaImages:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 97.29% 95.83% -1.47%
==========================================
Files 1 1
Lines 37 48 +11
==========================================
+ Hits 36 46 +10
- Misses 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #18 by introducing a bias to improve numerical stability in
IntegralArraycomputations.For floating-point arrays, a bias equal to the mean of the array is applied automatically.
For non-floating types (e.g. integers), the bias is ignored and behavior is unchanged.
Implementation details:
biasfield is added to IntegralArray.biasis added to every element of the array.bias * areais subtracted from the result.Currently, the bias can't be easily specified by the user, as I'm not sure how best to handle cases where the bias type doesn't match the type of the array.
Let me know if you'd like any changes or additional tests.