Skip to content

Add Some New Testing Infrastructure For Future Improvements To Highlight Repositioning Algo#889

Open
robin-macpherson wants to merge 3 commits intomasterfrom
improve-highlight-pos-algo
Open

Add Some New Testing Infrastructure For Future Improvements To Highlight Repositioning Algo#889
robin-macpherson wants to merge 3 commits intomasterfrom
improve-highlight-pos-algo

Conversation

@robin-macpherson
Copy link
Contributor

@robin-macpherson robin-macpherson commented Apr 25, 2024 •
edited
Loading

Description

Issue: #833

  • Continues our little refactor to split out our util code into more specific files, in this case our slate utils.
  • Adds some additional testing infra.
    • We were trying to fix or at least improve the current behavior when a highlight is very short, but this will require a pretty big effort. We at least documented the approach we'd like to take and added this extra testing infra to come back to this later.

@robin-macpherson robin-macpherson requested a review from Lanny April 25, 2024 15:45
@vercel
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
journaly ✅ Ready (Inspect) Visit Preview Apr 25, 2024 3:45pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lanny Lanny Awaiting requested review from Lanny

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

inline feedback experience refactor test Tests (thank you!)

Projects

Master Board
Status: In progress

Milestone

🧘🏻‍♂️ Journaly Stable Release 🙌🏼

Development

Successfully merging this pull request may close these issues.

1 participant

@robin-macpherson