Fix event/news detail CTA overlapping content on mobile#201
Open
Johngeorgesample wants to merge 3 commits intomainfrom
Open
Fix event/news detail CTA overlapping content on mobile#201Johngeorgesample wants to merge 3 commits intomainfrom
Johngeorgesample wants to merge 3 commits intomainfrom
Conversation
Mobile browser chrome (address bar, bottom toolbar) causes viewport height differences vs Chrome DevTools simulation. Add safe-area-inset-bottom padding to fixed CTA bars and scrollable content areas, and switch map container from 100vh to 100dvh. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for comfy-custard-bdea2e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The previous approach used absolute positioning for the CTA bar with bottom padding on the scrollable content to compensate. This breaks on real mobile devices because the content flows behind the CTA. Switch to a proper flex column layout: scrollable content uses flex-1 with min-h-0 and overflow-y-auto, CTA uses shrink-0 as an in-flow flex child. The CTA now naturally sits below the scroll area and never overlaps content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous approaches failed because EventDetails created its own scroll context (overflow-y-auto) inside the Sheet.Content which is already the scroll container. The absolute-positioned CTA overlapped content, and the flex layout CTA was unreachable. Now the content flows naturally within the Sheet's scroll container with no nested scroll context, and the CTA uses sticky bottom-0 to stay pinned at the bottom of the visible area while scrolling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env(safe-area-inset-bottom)padding to the fixed CTA bar in EventDetails and NewsDetails so it clears the iOS home indicator100vhto100dvhto account for dynamic mobile browser chrome (address bar, bottom toolbar)Context
On real mobile devices, the "View Event Website" / "View Source" CTA button overlaps the description text. This doesn't reproduce in Chrome DevTools responsive mode because simulated viewports don't account for mobile browser chrome shrinking the visible area.
Test plan
🤖 Generated with Claude Code