Add support for most common nested elements in block quotes#49
Add support for most common nested elements in block quotes#49rmecham wants to merge 5 commits intoJohnSundell:masterfrom
Conversation
|
I was excited to see your contribution @rmecham. I've tried this with an example from Gruber's markdown syntax page: This renders as two separate blockquote elements, but I'd expect it to be just one. |
|
Thinking aloud: The PR also adds explicit code for other fragments inside the blockquote, checking for Ideally that code would be reused - but it might need part of The |
|
I'll chime in and express my enthusiasm for this pull request. In particular, the idea of multiple In fact we can see that's just what the GitHub markdown parser does, if you inspect the following element, you'll see it is transformed to a single blockquote:
I had to do some gymnastics with inserting |
|
This is definitely something that is needed in Ink. |
I've had a go at updating Ink to support what I think are the HTML elements most commonly nested inside block quotes. I'm relatively new to Swift, so please let me know if you have any comments or suggestions.