feat(terra-draw): add renderAboveLayerId config param to mapbox/maplibre adapters#615
Open
jo-chemla wants to merge 1 commit intoJamesLMilner:mainfrom
Open
feat(terra-draw): add renderAboveLayerId config param to mapbox/maplibre adapters#615jo-chemla wants to merge 1 commit intoJamesLMilner:mainfrom
renderAboveLayerId config param to mapbox/maplibre adapters#615jo-chemla wants to merge 1 commit intoJamesLMilner:mainfrom
Conversation
renderAboveLayerId config param to mapbox/maplibre adaptersrenderAboveLayerId config param to mapbox/maplibre adapters
Owner
|
@jo-chemla thanks for your interest in the project and taking the time to trial this out - let's discuss on the issue thread: #394 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Following comment #394 (comment) this PR adds to the mapbox and maplibre adapters a config param
renderAboveLayerIdsimilar torenderBelowLayerId.The underlying adapter property is named
_renderAfterLayerIdto follow therenderBelowLayerIdsyntax - although maybe these could follow the maplibre/mapbox naming convention?Link to Issue
#394
PR Checklist