Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates documentation instructions and CI workflow to reflect the current docs build process, including using make targets, requiring doxygen, and installing hatch in the deploy workflow. Flow diagram for updated documentation contribution instructionsflowchart TD
A["Start: Want_to_contribute_docs"] --> B["Run_make_install_dev"]
B --> C["Install_doxygen_and_add_to_PATH"]
C --> D["Edit_root_README_md_and_docs_folder_files"]
D --> E["Run_make_docs_build_to_update_docs_directory"]
E --> F["Run_make_docs_serve_and_open_localhost_8000"]
F --> G["Review_changes_and_iterate"]
G --> H["Submit_PR_with_updated_docs"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The new CI step name has a typo (
Install Hathch); consider renaming it toInstall Hatchfor clarity and consistency. - Since the docs recommend a specific Hatch version (
hatch==1.15.1via pipx), consider aligning the CIpip install hatchwith that version (or explaining why CI uses an unpinned/latest Hatch) to avoid version drift between local and CI builds.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new CI step name has a typo (`Install Hathch`); consider renaming it to `Install Hatch` for clarity and consistency.
- Since the docs recommend a specific Hatch version (`hatch==1.15.1` via pipx), consider aligning the CI `pip install hatch` with that version (or explaining why CI uses an unpinned/latest Hatch) to avoid version drift between local and CI builds.
## Individual Comments
### Comment 1
<location> `.github/workflows/deploy-web.yaml:22` </location>
<code_context>
- uses: actions/setup-python@v5
with:
python-version: "3.12"
+ - name: Install Hathch
+ run: pip install hatch
- uses: actions/cache@v4
</code_context>
<issue_to_address>
**nitpick (typo):** Typo in step name ('Hathch' -> 'Hatch').
Renaming the step to `Install Hatch` will make the workflow logs clearer and more readable.
```suggestion
- name: Install Hatch
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update documentation contribution instructions and fix documentation build requirements in CI.
CI:
Documentation:
make install-dev, require manualdoxygeninstallation, and refer tomake docs-buildfor syncing docs.