Skip to content

Some more fixes for the Python module type hinting.#1415

Open
bcoconni wants to merge 2 commits intoJSBSim-Team:masterfrom
bcoconni:py_type_hinting
Open

Some more fixes for the Python module type hinting.#1415
bcoconni wants to merge 2 commits intoJSBSim-Team:masterfrom
bcoconni:py_type_hinting

Conversation

@bcoconni
Copy link
Copy Markdown
Member

@bcoconni bcoconni commented Apr 3, 2026

Fixes a few errors that were remaining after the PR #1393.

  • The stub file is renamed from _jsbsim.pyi to __init__.pyi so that it applies correctly to the module jsbsim instead of currently jsbsim._jsbsim.
  • Also fixes a pair of type hintings where the transition from SGPropertyNode to FGPropertyNode (see PR Remove the class FGPropertyNode #1270) has been overlooked.
  • Remove the useless statement from . import _jsbsim.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.12%. Comparing base (6c0e656) to head (d5ac5e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1415   +/-   ##
=======================================
  Coverage   25.12%   25.12%           
=======================================
  Files         169      169           
  Lines       18721    18721           
=======================================
  Hits         4703     4703           
  Misses      14018    14018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agodemar
Copy link
Copy Markdown
Contributor

agodemar commented Apr 3, 2026

OK to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants