Open
Conversation
Placement is now set on gateway if specified. Description was being set to Name. Preserve this if only Description is specified. Otherwise set Name from Name and Description from Description. Addressses #132
Contributor
|
I think it's going to be confusing to change things. My suggestion is to keep description as is and add 'extended-description' or similar. (Alternately (and long-term better): explicitly version the yaml files (add a "schema-version" or similar, and make this a breaking change in teh schema and simply require name with v2 schema. Then someone can do a massive regular change on the input data to update to the newer schema if they want to take advantage of name/description.) But just adding extended-description will be fine for now. As I said in my other comment, they're working on V4, and this is all subject to change anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placement is now set on gateway if specified.
Description was being set to Name. Preserve this if only Description is specified. Otherwise set Name from Name and Description from Description.
Addressses #132