db-analyser: avoid partial trace-ledger era-transition path#1939
Draft
dancewithheart wants to merge 2 commits intoIntersectMBO:mainfrom
Draft
db-analyser: avoid partial trace-ledger era-transition path#1939dancewithheart wants to merge 2 commits intoIntersectMBO:mainfrom
dancewithheart wants to merge 2 commits intoIntersectMBO:mainfrom
Conversation
f720b33 to
858a3a4
Compare
Author
|
The failing can be reproduced on cabal test storage-test --test-options='-p "ouroboros-storage.Storage.ChainDB.ChainDB q-s-m.sequential" --quickcheck-replay="(SMGen 1310011906619349515 3290980239361589411,61)"'it seems it is reported as #299. So this one looks unrelated to the change in this PR. |
Author
|
The failing cabal test byron-test --test-options='-p "Byron.simple convergence" --quickcheck-replay="(SMGen 13964393832207003311 14774351647257379649,80)"'So this also looks unrelated to this PR. Possibly related to #1294. |
Author
|
Converted to draft - probably without reproducing error manually and in tests the change is not that useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #48 by
so tracing is skipped at the boundary instead of crashing.
I was not able to reproduce the
db-analyser --trace-ledgercrash in tests.I added an integration-style test that runs
TraceLedgerProcessingonsynthesized Cardano test data and checks that analysis completes without
throwing.
Feedback would be very welcome: whether this is the right direction, and what
the best approach would be for a regression test.