26.1 compiles

[emmanuelvlad]

Overview

Made it compile on 26.1
Renamed adapter 26.1 to 26_1 (to keep the same syntax)
Removed reobf for new Minecraft versions (26.1 and above)

Submitter Checklist

• Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
• Ensure that the pull request title represents the desired changelog entry.
• New public fields and methods are annotated with @since TODO.
• I read and followed the contribution guidelines.

[SirYwell]

Renamed adapter 26.1 to 26_1 (to keep the same syntax)

This was intentional to be closer to the WE adapters.

[emmanuelvlad]

Renamed adapter 26.1 to 26_1 (to keep the same syntax)

This was intentional to be closer to the WE adapters.

Oops, thought it was a mistake, I renamed it back to 26.1

[SirYwell]

This only works on Paper I guess? Is there an easy way to make it work on Spigot? Otherwise it might make sense to fail regeneration more gracefully on Spigot.

[emmanuelvlad]

Indeed, paperweight overrides the only constructor on ServerLevel, requiring an extra argument PaperWorldLoader.LoadedWorldData

I added a throw exception on regenerations if the server is not Paper, let me know if it's what you had in mind!

[SirYwell]

The server currently crashes after using //regen due to the world being closed but not properly removed:

[17:26:38 ERROR]: Exception stopping the server
java.lang.IllegalStateException: Trying to schedule save when SavedDataStorage is already closed
	at net.minecraft.world.level.storage.SavedDataStorage.scheduleSave(SavedDataStorage.java:151) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.world.level.storage.SavedDataStorage.saveAndJoin(SavedDataStorage.java:221) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.server.level.ServerLevel.saveLevelData(ServerLevel.java:1490) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.server.level.ServerLevel.save(ServerLevel.java:1467) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.server.MinecraftServer.saveAllChunks(MinecraftServer.java:968) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:1091) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:941) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1408) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:304) ~[paper-26.1.2.jar:26.1.2-5-d61d8df]
	at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]

Not sure yet what the best approach here is, maybe a simple MinecraftServer#removeLevel call in removeWorldFromWorldsMap is fine?

[emmanuelvlad]

Sadly I cannot make FAWE run on spigot, neither the latest build on 1.21.11 works on my end.
Though I fixed an issue on spigot where it failed to detect the server's version

[SirYwell]

I'm okay with Spigot not working, but the //regen bug I mentioned above needs to be fixed.

[emmanuelvlad]

The issue is that we pass the original SavedDataStorage into the new ServerLevel constructor, closing it in cleanup caused that error since it's using the reference of the original world