fix: add a WrapperChunk to allow "Invalidating" a ChunkHolder on submission #3354
+723
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Oct 26, 2025
dordsor21
commented
- fixes issues where edits were not fully undone
- invalidate a ChunkHolder when submitting, via a "wrapper" to allow filters to be "aware"/forced to use a new ChunkHolder when it is submitted
- this also allows us to not submit a ChunkHolder in IQueueExtent#filter if the wrapper does not holder it anymore (i.e. it was forcibly submitted, and no more work was done)
Member
Author
|
Looks like it works fine + nothing new comes up in profiler Would also be good if others could test and try to reproduce the issue with history (to see if it's "definitely fixed") |
2 tasks
SirYwell
requested changes
Oct 30, 2025
Member
SirYwell
left a comment
SirYwell
left a comment
There was a problem hiding this comment.
I'm not a fan of all the mutability in general, but I guess there currently isn't really a better way without rewriting larger parts of the whole plugin.
...t-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/chunk/ChunkHolder.java
Outdated
Show resolved
Hide resolved
...t-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/chunk/ChunkHolder.java
Show resolved
Hide resolved
...t-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/chunk/ChunkHolder.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/chunk/WrapperChunk.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/chunk/WrapperChunk.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/queue/IQueueChunk.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/queue/IQueueExtent.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@SirYwell poke |
dordsor21
force-pushed
the
fix/improve-chunk-holder-use
branch
from
76a3682 to
bcd35ff
Compare
SirYwell
approved these changes
Nov 30, 2025
dordsor21
force-pushed
the
fix/improve-chunk-holder-use
branch
from
8b4330c to
147c544
Compare
…ission - fixes issues where edits were not fully undone - invalidate a ChunkHolder when submitting, via a "wrapper" to allow filters to be "aware"/forced to use a new ChunkHolder when it is submitted - this also allows us to *not* submit a ChunkHolder in IQueueExtent#filter if the wrapper does not holder it anymore (i.e. it was forcibly submitted, and no more work was done)
dordsor21
force-pushed
the
fix/improve-chunk-holder-use
branch
from
147c544 to
6157c98
Compare
NotMyFault
approved these changes
Dec 25, 2025
Collaborator
NotMyFault
left a comment
NotMyFault
left a comment
There was a problem hiding this comment.
No ingame testing but looks reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.