Fix: when app is put in bg, SSE connection executes stream completely#43
Open
anuraggoel-tif wants to merge 1 commit intoImgkl:mainfrom
Open
Fix: when app is put in bg, SSE connection executes stream completely#43anuraggoel-tif wants to merge 1 commit intoImgkl:mainfrom
anuraggoel-tif wants to merge 1 commit intoImgkl:mainfrom
Conversation
Imgkl
previously approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced change in eventflux-2.2.1/lib/client.dart- disconnect() function now instead of directly calling _stop() first checks if _streamController is null or not and if not null then lets the stream complete itself and then connection closes after timeout of 5 seconds.
in line: 405 ensured that we clean up the internal resources so consumers can see closed stream
in line: 406 added fix to notify connection close so that callers can free up their resources.