Support step and list attributes on DateTime picker#1960
Open
ojuschugh1 wants to merge 1 commit intoIgalia:mainfrom
Open
Support step and list attributes on DateTime picker#1960ojuschugh1 wants to merge 1 commit intoIgalia:mainfrom
ojuschugh1 wants to merge 1 commit intoIgalia:mainfrom
Conversation
Handle the HTML step attribute on date/time inputs by snapping the selected value to the nearest valid step boundary when the user confirms. For Chromium, datalist suggestions are also forwarded and shown in a Spinner above the pickers so the user can pick from them. On the Gecko side step is read from GeckoView directly but datalist is not exposed by the engine so we just fall back gracefully. Fixes Igalia#1257
ojuschugh1
force-pushed
the
fix/datetime-step-list-1257
branch
from
ba2c332 to
6869eb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the HTML step attribute on date/time inputs by snapping the selected value to the nearest valid step boundary when the user confirms. For Chromium, datalist suggestions are also forwarded and shown in a Spinner above the pickers so the user can pick from them.
On the Gecko side step is read from GeckoView directly but datalist is not exposed by the engine so we just fall back gracefully.
Fixes #1257