Web engine shows a plain color page while loading about:// URLs#1849
Web engine shows a plain color page while loading about:// URLs#1849felipeerias wants to merge 1 commit intomainfrom
Conversation
About pages are provided by a native UI. However, sometimes an error message can be seen for a brief moment before that native UI is displayed. This change shows a plain color page for about:// URLs instead of the standard error page to avoid those unwanted content flashes. Fixes #1834
felipeerias
force-pushed
the
felipeerias/errorPlaceholder
branch
from
808d6eb to
75c7f61
Compare
javifernandez
left a comment
javifernandez
left a comment
There was a problem hiding this comment.
The "solution" seems to solve the issue. However, I wonder whether we should keep the html (or even the bytes) in memory given that we are going to create it for every navigation, if I have understood the issue properly.
felipeerias
changed the title
svillar
left a comment
svillar
left a comment
There was a problem hiding this comment.
I think I don't fully understand the problem. Looks like this is something that happens with the new tab page? Also why an error is shown? Shouldn't we fix that instead of showing a plain color page?
|
The idea was to integrate the new tab with the rest of the navigation so back/forward, etc. work as expected. As a result, The error message is shown because Wolvic uses |
|
Gecko also shows an error for |
felipeerias
added
the
release_candidate
javifernandez
left a comment
javifernandez
left a comment
There was a problem hiding this comment.
As commented offline this is not the right solution for the issue described in the bug report. We should add the new Wolvic's about-page in Gecko, so it's properly recognized as a valid url.
However, this solution won't be on time for the release and the issue has been classified as blocker. I can accept this temporary solution for now.
If we want to do this, please apply the patch in the release branch but let's not land it in main |
javifernandez
added
release_candidate
shynekomaid
left a comment
shynekomaid
left a comment
There was a problem hiding this comment.
I suggest height: 100dvh; Because something tells me that if I change the window size, there may be a white stripe at the bottom.
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <style>html, body { margin: 0; height: 100%; background: %backgroundColor%; }</style> |
There was a problem hiding this comment.
I suggest height: 100dvh; Because something tells me that if I change the window size, there may be a white stripe at the bottom.
4 participants
About pages are provided by a native UI. However, sometimes an error message can be seen for a brief moment before that native UI is displayed.
This change shows a plain color page for about:// URLs instead of the standard error page to avoid those unwanted content flashes.
Fixes #1834