test: Fixed nondeterministic failures in factoryTest() #6494
Open
yonghanlin wants to merge 1 commit intoINRIA:masterfrom
Open
test: Fixed nondeterministic failures in factoryTest() #6494yonghanlin wants to merge 1 commit intoINRIA:masterfrom
yonghanlin wants to merge 1 commit intoINRIA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a nondeterministic test failure in
FactoryTest.factoryTest()within.module when running with NonDex.Problem
The nondeterminism occurs because the test randomly generates arguments for every
create*()method. These arguments come from unordered collections and mixed element types, so their structure can change between runs.Observed failures include:
CtTypePattern,CtUnnamedPattern) used outside of valid pattern-matching contexts (e.g.,instanceoforswitch).CtFieldarguments, causing errors in methods likecreateVariableReads()orcreateVariableAssignments().CtRecord) being used for constructs that records cannot legally contain.Reproduce Test
To reproduce the failure, run NonDex on
.module using the following commands:The Fix
The fix introduces argument normalization before invoking each factory method:
CtTypePattern,CtUnnamedPattern) with a harmless literal (CtLiteral(0)), which is a valid expression in all contexts.CtFieldlacks adeclaringType, attach it to a synthetic dummy host class (TmpHost_*) and ensure it has a validtypeandsimpleName.CtRecordarguments with dummy classes when the target method requires a host that supports instance members.createVariableReadsandcreateVariableAssignmentsensures that every nested field reference has a valid host.