Skip to content

Update crazyflie.py#818

Open
ntukenmez3 wants to merge 2 commits intoIMRCLab:mainfrom
ntukenmez3:patch-1
Open

Update crazyflie.py#818
ntukenmez3 wants to merge 2 commits intoIMRCLab:mainfrom
ntukenmez3:patch-1

Conversation

@ntukenmez3
Copy link

def position(self) in crazyswarm (ROS) has been updated for crazyswarm2 (ROS2) as def get_position_from_tf(self). This function allows the developer to get linear position data from crazyflie according to 'world' frame.

def position(self) in crazyswarm (ROS) has been updated for crazyswarm2 (ROS2) as def get_position_from_tf(self).
This function allows the developer to get linear position data from crazyflie according to 'world' frame.
the function name has been changed.
@knmcguire
Copy link
Collaborator

Hi! I think this is perhaps better to use the Pose topic for this though instead of the transform tbh

@ntukenmez3
Copy link
Author

I will use it too :)
May I ask one more thing about the pull request I made in the last week?
I couldn't get the reason why the updated crazyflie.py script get docker error?
Do we need to change additional settings to get rid of this issue?

@knmcguire
Copy link
Collaborator

Ah oke. But would it be possible to get the position data from the pose ros topic and not from the transform tree in this PR?

About the CI failing, If you check the error messages you see there are a lot of flake8 formatting errors in the CI flagged. It should provide a list of which once it has marked.

If you search online you can also find some terminal based tools to fix these type of flake8 problems either in VScode or from your terminal in the files

Copy link
Collaborator

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • cf.position from pose topics
  • fix flake8 issues in ci

@knmcguire
Copy link
Collaborator

Ah sorry I missed the context of the following issue (try to always connect these to your PRs #815)

Here I saw that you had issues with using the topic directly. I'm not a fan of getting it from transforms itself but perhaps @whoenig can pitch in here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants