Add support for hour(timestamp_ntz)#1974
Open
Mariamalmesfer wants to merge 1 commit intots_ntz_ibmfrom
Open
Conversation
rui-mo
reviewed
Apr 29, 2026
|
|
||
| FOLLY_ALWAYS_INLINE void call( | ||
| int32_t& result, | ||
| const arg_type<TimestampNTZ>& timestamp) { |
There was a problem hiding this comment.
Sorry for the confusion, we need to use TimestampUtcType. TimestampNTZ is being removed (see facebookincubator#16886). You might could refer to struct TimestampPlusOneFunction for how to register a function for both Timestamp and TimestampUtc types.
Collaborator
Author
There was a problem hiding this comment.
No worries, switched to TimestampUtcType following the TimestampPlusOneFunction pattern
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
484eb10 to
5b830a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.