fix(admin): add missing URL field in server edit modal#4493
Open
ecthelion77 wants to merge 1 commit intoIBM:mainfrom
Open
fix(admin): add missing URL field in server edit modal#4493ecthelion77 wants to merge 1 commit intoIBM:mainfrom
ecthelion77 wants to merge 1 commit intoIBM:mainfrom
Conversation
The server edit modal is missing the URL input field that servers.js
references via safeGetElement('edit-server-url'). The create server
modal has the URL field, but the edit modal was missing it since PR IBM#337
(July 2025). This causes the URL to not be editable when editing a
server configuration.
Add the URL input field between the Name and Description fields in
the server-edit-modal form, matching the pattern from the create modal.
Signed-off-by: Olivier Gintrand <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Fixes #4492
📌 Summary
The server edit modal is missing the URL input field that
servers.jsreferences viasafeGetElement('edit-server-url'). The create server modal has the URL field, but the edit modal does not — making it impossible to view or modify a server's URL after creation.Likely a regression from PR #337 (July 2025) which restructured the server modals.
🔁 Reproduction Steps
See issue #4492 for details.
🐞 Root Cause
The
<input id="edit-server-url">element was never added to theserver-edit-modalform inadmin.html. The JavaScript populates it viasafeGetElement('edit-server-url')which silently returns null, so the URL is lost on save.💡 Fix Description
Add the URL input field (
type="url",id="edit-server-url") to the server edit modal, between the Name and Description fields, matching the create modal pattern:Single file change:
mcpgateway/templates/admin.html(+14 lines).🧪 Verification
make lintmake test📐 MCP Compliance
✅ Checklist