935 unable to focus member search input for invites#936
Open
KevinTriplett wants to merge 4 commits intodevfrom
Open
935 unable to focus member search input for invites#936KevinTriplett wants to merge 4 commits intodevfrom
KevinTriplett wants to merge 4 commits intodevfrom
Conversation
Collaborator
|
oh shoot I just did this work on dev 😬 |
Collaborator
|
dang, I think I like your version better. but also I did some minor UI improvements to the dialog, and also fixed the attending members dialog at the same time in the same way... I think I'll stick with what I did on dev. although, this one could maybe be complimentary. and prevent future issues with the focus being captured in the post dialog fully |
Contributor
Author
|
Oh darn -- well, maybe take what I did and fold into yours? I'm glad you improved the UI -- also, check the last commit and fold it in, it answers a question. |
Contributor
Author
|
Do we close this PR or ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #935
This addresses an uncanny bug report I filed yesterday.