修复因rstrip导致的bug #55
Open
修复因rstrip导致的bug #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in URL processing where rstrip('/v1') was incorrectly used to remove the /v1 suffix from base URLs. The issue is that rstrip() treats its argument as a set of characters to remove, not as a complete suffix, which could lead to incorrect URL manipulation (e.g., removing multiple 'v' and '1' characters).
Key Changes:
- Replaced
.rstrip('/').rstrip('/v1')with a proper suffix check using.endswith('/v1')followed by string slicing[:-3] - Applied the fix consistently across three locations: text client initialization and two API testing functions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/utils/text_client.py | Fixed base_url processing in TextChatClient initialization to correctly remove '/v1' suffix |
| backend/routes/config_routes.py | Fixed base_url processing in _test_openai_compatible() and _test_image_api() functions to correctly handle '/v1' suffix removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.