Skip to content

Shape factor using constant memory#1328

Open
AlexanderSinn wants to merge 9 commits intoHi-PACE:developmentfrom
AlexanderSinn:shape_factor_using_constant_memory
Open

Shape factor using constant memory#1328
AlexanderSinn wants to merge 9 commits intoHi-PACE:developmentfrom
AlexanderSinn:shape_factor_using_constant_memory

Conversation

@AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Dec 11, 2025

hipace.depos_order_xy = 2
hipace.depos_derivative_type = 1

PR:

TinyProfiler total time across processes [min...avg...max]: 12.77 ... 12.77 ... 12.77

------------------------------------------------------------------------------------------------------
Name                                                   NCalls  Excl. Min  Excl. Avg  Excl. Max   Max %
------------------------------------------------------------------------------------------------------
DepositCurrent_PlasmaParticleContainer()                 1001      3.369      3.369      3.369  26.38%
AdvancePlasmaParticles()                                 1000      3.304      3.304      3.304  25.88%
ExplicitDeposition()                                     1000      3.279      3.279      3.279  25.68%
AdvanceBeamParticlesSlice()                              1000     0.2679     0.2679     0.2679   2.10%
DepositCurrentSlice_BeamParticleContainer()              2000      0.115      0.115      0.115   0.90%

Dev:


TinyProfiler total time across processes [min...avg...max]: 13.8 ... 13.8 ... 13.8

------------------------------------------------------------------------------------------------------
Name                                                   NCalls  Excl. Min  Excl. Avg  Excl. Max   Max %
------------------------------------------------------------------------------------------------------
ExplicitDeposition()                                     1000      3.708      3.708      3.708  26.87%
AdvancePlasmaParticles()                                 1000      3.697      3.697      3.697  26.79%
DepositCurrent_PlasmaParticleContainer()                 1001      3.461      3.461      3.461  25.08%
AdvanceBeamParticlesSlice()                              1000     0.3929     0.3929     0.3929   2.85%
DepositCurrentSlice_BeamParticleContainer()              2000     0.1137     0.1137     0.1137   0.82%
  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added GPU Related to GPU acceleration performance optimization, benchmark, profiling, etc. labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GPU Related to GPU acceleration performance optimization, benchmark, profiling, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant