Skip to content

test with clang-tidy settings from AMReX#1325

Open
AlexanderSinn wants to merge 26 commits intoHi-PACE:developmentfrom
AlexanderSinn:test_with_clang_tidy_settings_from_AMReX
Open

test with clang-tidy settings from AMReX#1325
AlexanderSinn wants to merge 26 commits intoHi-PACE:developmentfrom
AlexanderSinn:test_with_clang_tidy_settings_from_AMReX

Conversation

@AlexanderSinn
Copy link
Member

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments