fix: UIAlert stringifies value (#1424)

[dtakahashi333]

This patch fixes a potential issue in UIAlert where values were being stringified unexpectedly, by introducing the parseDataValue() function, which attempts to recover the original JavaScript value type.

[jelveh]

Thanks @dtakahashi333 for this! At first glance, this makes sense; but I need to do some deep testing as a lot of devs depend on UIAlert. If you're testing right now as well, do let me know if something comes up, I'd like to help/discuss it.

[dtakahashi333]

@jelveh I understand your concern, and I totally agree with you. Considering the impact of this update, I believe it's fine to leave it as is unless a user reports it as an issue.

Based on my inspection, as long as html_encode() behaves as expected, which returns an empty string for false, I believe the issue @KernelDeimos mentioned will not occur.

Do you have any thoughts on this?

[jelveh]

This makes sense. The old code (causing the quirk) is not very elegant though and I wish we could just replace it. Let me do more testing and I'll get back to you

[dtakahashi333]

@jelveh Do you happen to know if the Puter project is planning to use any GUI test automation tools, like Playwright, Cypress, or similar?

[jelveh]

This is something we'd love to have! Would you be interested in taking a stab at it?

[dtakahashi333]

@jelveh Sure, I’d be happy to!

[jelveh]

Awesome! Could you either open an issue or email me at [email protected] so that I could help you get started on it? Let me know what you will need and how we could plan this. I'd be happy to help in any way I can.