Fix build failures on macOS in netcpu_osx.c#67
Open
ryandesign wants to merge 2 commits intoHewlettPackard:masterfrom
Open
Fix build failures on macOS in netcpu_osx.c#67ryandesign wants to merge 2 commits intoHewlettPackard:masterfrom
ryandesign wants to merge 2 commits intoHewlettPackard:masterfrom
Conversation
Fixes build failure: error: implicit declaration of function 'mach_port_deallocate' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
Fixes build failure: netcpu_osx.c:73:37: error: too few arguments to function call, expected 2, have 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netperf 2.7.0 fails to build on macOS 10.15 or later with Xcode 12 or later because as of Xcode 12 implicit declaration of function is an error. (The compiler behaves by default as if
-Werror=implicit-function-declarationhas been specified.) I originally reported this to MacPorts here.After applying 0b0cbbe to fix implicit declarations of
readandclose, the remaining error is:After fixing that by including the right header (or uncommenting the inclusion of the right header), the error is then:
I don't know whether the signature of mach_port_deallocate changed since this code was added or whether the code was always wrong. Mach functions are hard to find documentation for, so much so that I don't know what the second (or, it turns out, first) argument should be, but every code sample I found that used this function used
mach_task_self()as the first argument, so that's what I used here. It at least compiles now.