nettest_omni: Remove duplicate variable definitions#46
Open
kraj wants to merge 1 commit intoHewlettPackard:masterfrom
Open
nettest_omni: Remove duplicate variable definitions#46kraj wants to merge 1 commit intoHewlettPackard:masterfrom
kraj wants to merge 1 commit intoHewlettPackard:masterfrom
Conversation
These defines are already defined in nettest_bsd.c and exported by nettest_bsd.h this should fix build with -fno-common Signed-off-by: Khem Raj <raj.khem@gmail.com>
yanan-fu
added a commit
to yanan-fu/tp-qemu
that referenced
this pull request
Feb 5, 2021
patch HewlettPackard/netperf#46 to the existing netperf Signed-off-by: Yanan Fu <yfu@redhat.com>
|
Would this also solve for "Unable to compile on Fedora 32" #42? |
Author
i think so |
cliping
added a commit
to cliping/avocado-vt
that referenced
this pull request
Jul 9, 2021
When run 'make' command to compile netperf, meet following error: gcc -o netperf netperf.o netlib.o netsh.o nettest_bsd.o nettest_dlpi.o nettest_unix.o nettest_xti.o nettest_sctp.o nettest_sdp.o nettest_omni.o net_uuid.o dscp.o netcpu_none.o netrt_none.o netdrv_none.o netslot_none.o netsys_none.o netsec_none.o -lm /usr/bin/ld: nettest_omni.o:(.bss+0x398): multiple definition of `loc_nodelay'; nettest_bsd.o:(.bss+0x20): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x39c): multiple definition of `rem_nodelay'; nettest_bsd.o:(.bss+0x24): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a0): multiple definition of `loc_sndavoid'; nettest_bsd.o:(.bss+0x30): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a4): multiple definition of `loc_rcvavoid'; nettest_bsd.o:(.bss+0x34): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a8): multiple definition of `rem_sndavoid'; nettest_bsd.o:(.bss+0x38): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3ac): multiple definition of `rem_rcvavoid'; nettest_bsd.o:(.bss+0x3c): first defined here collect2: error: ld returned 1 exit status make[3]: *** [Makefile:443: netperf] Error 1 One patch [1] is to fix this issue. According to this patch to update netperf package. [1] HewlettPackard/netperf#46 Signed-off-by: lcheng <lcheng@redhat.com>
cliping
added a commit
to cliping/avocado-vt
that referenced
this pull request
Jul 22, 2021
When run 'make' command to compile netperf, meet following error: gcc -o netperf netperf.o netlib.o netsh.o nettest_bsd.o nettest_dlpi.o nettest_unix.o nettest_xti.o nettest_sctp.o nettest_sdp.o nettest_omni.o net_uuid.o dscp.o netcpu_none.o netrt_none.o netdrv_none.o netslot_none.o netsys_none.o netsec_none.o -lm /usr/bin/ld: nettest_omni.o:(.bss+0x398): multiple definition of `loc_nodelay'; nettest_bsd.o:(.bss+0x20): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x39c): multiple definition of `rem_nodelay'; nettest_bsd.o:(.bss+0x24): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a0): multiple definition of `loc_sndavoid'; nettest_bsd.o:(.bss+0x30): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a4): multiple definition of `loc_rcvavoid'; nettest_bsd.o:(.bss+0x34): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a8): multiple definition of `rem_sndavoid'; nettest_bsd.o:(.bss+0x38): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3ac): multiple definition of `rem_rcvavoid'; nettest_bsd.o:(.bss+0x3c): first defined here collect2: error: ld returned 1 exit status make[3]: *** [Makefile:443: netperf] Error 1 One patch [1] is to fix this issue. According to this patch to update netperf package. [1] HewlettPackard/netperf#46 Signed-off-by: lcheng <lcheng@redhat.com>
ana
pushed a commit
to ana/avocado-vt
that referenced
this pull request
Aug 9, 2021
When run 'make' command to compile netperf, meet following error: gcc -o netperf netperf.o netlib.o netsh.o nettest_bsd.o nettest_dlpi.o nettest_unix.o nettest_xti.o nettest_sctp.o nettest_sdp.o nettest_omni.o net_uuid.o dscp.o netcpu_none.o netrt_none.o netdrv_none.o netslot_none.o netsys_none.o netsec_none.o -lm /usr/bin/ld: nettest_omni.o:(.bss+0x398): multiple definition of `loc_nodelay'; nettest_bsd.o:(.bss+0x20): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x39c): multiple definition of `rem_nodelay'; nettest_bsd.o:(.bss+0x24): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a0): multiple definition of `loc_sndavoid'; nettest_bsd.o:(.bss+0x30): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a4): multiple definition of `loc_rcvavoid'; nettest_bsd.o:(.bss+0x34): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a8): multiple definition of `rem_sndavoid'; nettest_bsd.o:(.bss+0x38): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3ac): multiple definition of `rem_rcvavoid'; nettest_bsd.o:(.bss+0x3c): first defined here collect2: error: ld returned 1 exit status make[3]: *** [Makefile:443: netperf] Error 1 One patch [1] is to fix this issue. According to this patch to update netperf package. [1] HewlettPackard/netperf#46 Signed-off-by: lcheng <lcheng@redhat.com>
sayboras
added a commit
to sayboras/netperf
that referenced
this pull request
Aug 20, 2022
These defines are already defined in nettest_bsd.c and exported by nettest_bsd.h this should fix build with -fno-common Thanks to Khem Raj raj.khem@gmail.com Relates: HewlettPackard#46
sayboras
added a commit
to sayboras/netperf
that referenced
this pull request
Aug 20, 2022
These defines are already defined in nettest_bsd.c and exported by nettest_bsd.h this should fix build with -fno-common Thanks to Khem Raj raj.khem@gmail.com Relates: HewlettPackard#46 Signed-off-by: Tam Mach <sayboras@yahoo.com>
jrajahalme
added a commit
to cilium/packer-ci-build
that referenced
this pull request
Jan 4, 2023
Pull from sayboras/netperf that has the multiple definitions fix (HewlettPackard/netperf#46). Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jtaleric
approved these changes
Jan 31, 2023
jtaleric
left a comment
jtaleric
left a comment
There was a problem hiding this comment.
lgtm, tested this on ubi9 and was able to successfully build netperf. Without this patch it was unable to build.
jrajahalme
added a commit
to cilium/packer-ci-build
that referenced
this pull request
Feb 19, 2023
Pull from sayboras/netperf that has the multiple definitions fix (HewlettPackard/netperf#46). Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added a commit
to cilium/packer-ci-build
that referenced
this pull request
May 12, 2023
Pull from sayboras/netperf that has the multiple definitions fix (HewlettPackard/netperf#46). Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
|
@jtaleric Can you please merge this PR, with out this netperf build fails for all platform |
|
@kirbychris @GavinB-hpe sorry for the spam can anyone you (not sure if any one of active here if not can you please help us to reach out to right person ) please help us to merge this PR we are kind of stuck here as we did not get maintainer list in repo |
I don't have that authority 😢 |
|
@HewlettPackard @ChrisLynchHPE can you please help here |
Member
|
I do not own this repository and have no knowledge on the code. I am unaware who even maintains this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These defines are already defined in nettest_bsd.c and exported by
nettest_bsd.h this should fix build with -fno-common
Signed-off-by: Khem Raj raj.khem@gmail.com