You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make operations on tile can use pk instruction. However, this design is not decent to me. Feel free to share your idea and deprecate this design.
Besides, I did try to use if constexpr to check whether a class or structure has member function op_pk2(). However, this design doesn't work with latest hipcc... Hipcc still tries to compile the false path even if it knows the result of condiction at compile time.
Ideally, we can have a if constexpr to check whether a class or structure has the op_pk2() member function.
Alternatively, we should just create a mul_pk struct and add a contexpr bool hasPacked; field to every operator struct. That way we can have a single bin_map function.
bin_map functions that operate over a single register should throw a compile-time error if it's used with a packed instruction. Otherwise, the other bin_map functions would just skip over every other register when the operator has hasPacked set to true.
The developer would now have the flexibility of choosing between using a packed or non-packed instruction.
I think instead of hk::bin_map_pk2<0, 0, hkm::mul_vgpr>(oaccu, oaccu, rescale);, we can make things a bit prettier in the library and do something like hk::mul_vgpr_pk2<0, 0>(oaccu, oaccu, rescale);.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make operations on tile can use pk instruction. However, this design is not decent to me. Feel free to share your idea and deprecate this design.
Besides, I did try to use
if constexprto check whether a class or structure has member functionop_pk2(). However, this design doesn't work with latest hipcc... Hipcc still tries to compile the false path even if it knows the result of condiction at compile time.