Fix IME input and wide-character rendering in terminal view#73
Open
benenen wants to merge 1 commit intoHarzu:masterfrom
Open
Fix IME input and wide-character rendering in terminal view#73benenen wants to merge 1 commit intoHarzu:masterfrom
benenen wants to merge 1 commit intoHarzu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
This change updates the terminal view to participate in iced's input method flow instead of relying only on raw keyboard events.
Preedit text is tracked in widget state without being written to the PTY, while committed text is forwarded through the existing
backend write path as UTF-8 bytes.
It also adjusts terminal rendering for full-width characters so CJK glyphs are positioned using wide-cell alignment, which fixes
the visual overlap that could occur between the last English character and the first Chinese character after IME commit.
Test plan
cargo test🤖 Generated with Claude Code