Skip to content

fixed baseline inlay hint #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HanzoDev1375 merged 1 commit into from
Dec 3, 2025
Merged

fixed baseline inlay hint #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions core/src/main/java/io/github/rosemoe/sora/widget/CodeEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,12 @@ void drawInlay(Canvas canvas, Inlay inlay) {
currentCharWidth = measureText(lineContent, inlay.column, 1, inlay.line);
}
float inlayStartX = charX + currentCharWidth;
float baselineY = charY + getRowBaseline(0);

float verticalPadding = getDpUnit() * 1;
Paint.FontMetrics fm = mPaintGraph.getFontMetrics();
float textHeight = fm.descent - fm.ascent;
float baselineY = charY - (textHeight / 2) - verticalPadding * 2;

Paint.Style oldStyle = mPaintGraph.getStyle();
float oldTextSize = mPaintGraph.getTextSize();
Typeface oldTypeface = mPaintGraph.getTypeface();
Expand All @@ -535,10 +540,8 @@ void drawInlay(Canvas canvas, Inlay inlay) {
mPaintGraph.setTextSize(mPaint.getTextSize() * 0.85f);
mPaintGraph.setTypeface(getTypefaceText());
float textWidth = mPaintGraph.measureText(inlay.text);
Paint.FontMetrics fm = mPaintGraph.getFontMetrics();
float textHeight = fm.descent - fm.ascent;

float horizontalPadding = getDpUnit() * 4;
float verticalPadding = getDpUnit() * 1;
float marginFromChar = getDpUnit() * 2;
float bgWidth = textWidth + horizontalPadding * 2;
float bgHeight = textHeight + verticalPadding * 2;
Expand Down